fix(core): ser/de for FileKind
#3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
fix/serialization
branch
from
e16f73e
to
6ddd405
Compare
CodSpeed Performance ReportMerging #3736 will improve performances by 6.44%Comparing Summary
Benchmarks breakdown
|
Conaclos
approved these changes
Aug 28, 2024
Conaclos
reviewed
Aug 28, 2024
ematipico
force-pushed
the
fix/serialization
branch
from
1629625
to
d696c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix a regression where
FileKindcan't be serialized/deserialized from an array of strings.Test Plan
Tests added, I will need to check it against biomejs/website#1012