Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ci): speedup free disk space action #3694

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Jayllyz
Copy link
Sponsor Contributor

@Jayllyz Jayllyz commented Aug 21, 2024

Summary

free-disk-space is useful but quite slow.
A contributor to rspack has made a fork which is faster.

I have also tested another version using https://lib.rs/crates/rmz but the installation time makes it slower.

Related PR with the changes : jlumbroso/free-disk-space#26

Test Plan

Tested on a fork + rspack is also already using it.

@Jayllyz Jayllyz marked this pull request as ready for review August 21, 2024 18:26
@nhedger
Copy link
Member

nhedger commented Aug 21, 2024

Do we know if the fork will be maintained? If not perhaps we should wait for the PR to get merged.

@Jayllyz
Copy link
Sponsor Contributor Author

Jayllyz commented Aug 21, 2024

I dont know.

@nhedger
Copy link
Member

nhedger commented Aug 21, 2024

I have also tested another version using https://lib.rs/crates/rmz but the installation time makes it slower.

Was that using cargo install or by downloading the prebuilt binary from GitHub ?

@Jayllyz
Copy link
Sponsor Contributor Author

Jayllyz commented Aug 21, 2024

Was that using cargo install or by downloading the prebuilt binary from GitHub ?

cargo install rmz + sudo ln -s /home/runner/.cargo/bin/rmz /usr/local/bin/rmz

EDIT with prebuilt bin it's way better, all settings to true:
(https://github.com/Jayllyz/free-disk-space/actions/runs/10495761924/job/29074900233)
image

I've made a comment to his PR.

@ematipico
Copy link
Member

Do we know if the fork will be maintained? If not perhaps we should wait for the PR to get merged.

Well, the action we use now isn't that maintained too (the PR was open almost a month ago). I don't mind using this alternative

@ematipico ematipico merged commit 21b0ddb into biomejs:main Aug 27, 2024
2 checks passed
@Jayllyz Jayllyz deleted the perf/speedup-free-disk-space branch August 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants