Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): missing codegen check #3692

Merged
merged 3 commits into from
Aug 21, 2024
Merged

fix(ci): missing codegen check #3692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
212cd7f
fix(ci): missing codegen check
Jayllyz Aug 21, 2024
7e7f6b0
fix: format config.toml
Jayllyz Aug 21, 2024
fc185d1
chore: use new codegen alias in justfile
Jayllyz Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ codegen-bindings = "run -p xtask_codegen --features schema -- bindings"
codegen-configuration = "run -p xtask_codegen --features configuration -- configuration"
# updates a newly created crate
codegen-license = "run -p xtask_codegen --features license -- license"
codegen-migrate = "run -p xtask_codegen --features configuration -- migrate-eslint"
Jayllyz marked this conversation as resolved.
Show resolved Hide resolved
codegen-schema = "run -p xtask_codegen --features schema -- schema"
contributors = "run -p xtask_contributors --"
coverage = "run -p xtask_coverage --profile=release-with-debug --"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ jobs:
run: cargo codegen-schema
- name: Run the bindings codegen
run: cargo codegen-bindings
- name: Run the migrate codegen
run: cargo codegen-migrate
- name: Check for git diff
run: |
if [[ `git status --porcelain` ]]; then
Expand Down
12 changes: 0 additions & 12 deletions crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ upgrade-tools:
gen-all:
cargo run -p xtask_codegen -- all
cargo codegen-configuration
cargo run -p xtask_codegen --features configuration -- migrate-eslint
cargo codegen-migrate
just gen-bindings
just format

Expand All @@ -35,7 +35,7 @@ gen-bindings:
gen-lint:
cargo run -p xtask_codegen -- analyzer
cargo codegen-configuration
cargo run -p xtask_codegen --features configuration -- migrate-eslint
cargo codegen-migrate
just gen-bindings
cargo run -p rules_check
just format
Expand Down