fix(configuration): merge inherited overrides #3671
Merged
+356
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
force-pushed
the
conaclos/3544
branch
from
1aff85b
to
6ac1d1e
Compare
Conaclos
force-pushed
the
conaclos/3544
branch
from
6ac1d1e
to
6986fcb
Compare
ematipico
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3544
We no longer overwrite the
overridesfield. This fixes #3544 and allows inheriting theoverridesof an extended configuration.I took the opportunity of adding more implementations of the
Mergetrait. Basically I implementedMergefor the same types asDeserializableimplement.Test Plan
I added a migration test.