Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint/useAriaPropsSupportedByRole): add rule #3644

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

ryo-ebata
Copy link
Contributor

@ryo-ebata ryo-ebata commented Aug 12, 2024

Summary

Enforce that ARIA properties are valid for the roles that are supported by the element.

Porting eslint-plugin-jsx-a11y/role-supports-aria-props rule
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/role-supports-aria-props.md

Issue:
Close #2613

Test Plan

eslint-plugin-jsx-a11y's test cases covered.
And several deprecated elements have been removed from the test cases.
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/role-supports-aria-props-test.js

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Aug 12, 2024
Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #3644 will not alter performance

Comparing ryo-ebata:useAriaPropsSupportedByRole (a2ca26d) with main (47987e8)

Summary

✅ 101 untouched benchmarks

@github-actions github-actions bot added the A-CLI Area: CLI label Aug 18, 2024
@ryo-ebata ryo-ebata marked this pull request as ready for review August 18, 2024 14:38
@ryo-ebata
Copy link
Contributor Author

ryo-ebata commented Aug 26, 2024

@Conaclos
Excuse me, may I ask you to review again?

Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution, and sorry for the delay!

@Conaclos Conaclos merged commit 80b9db5 into biomejs:main Aug 26, 2024
12 checks passed
@ryo-ebata
Copy link
Contributor Author

ryo-ebata commented Aug 26, 2024

@Conaclos

Looks good to me! Thanks for your contribution, and sorry for the delay!

No Problem, thanks for review & merge!

@ryo-ebata ryo-ebata deleted the useAriaPropsSupportedByRole branch August 26, 2024 20:30
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement jsx-a11y/role-supports-aria-props
3 participants