Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove atty #363

Merged
merged 1 commit into from
Sep 21, 2023
Merged

chore: remove atty #363

merged 1 commit into from
Sep 21, 2023

Conversation

ematipico
Copy link
Member

Summary

atty has become essentially obsolete because now Rust std has a built-in method: https://doc.rust-lang.org/std/io/trait.IsTerminal.html#tymethod.is_terminal

This PR removes it from the project

Test Plan

CI should pass

@ematipico ematipico temporarily deployed to Website deployment September 21, 2023 07:45 — with GitHub Actions Inactive
@github-actions github-actions bot added A-CLI Area: CLI A-Parser Area: parser A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages labels Sep 21, 2023
@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47808 47808 0
Failed 1055 1055 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1764 1764 0
Failed 4448 4448 0
Panics 0 0 0
Coverage 28.40% 28.40% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 571 571 0
Failed 68 68 0
Panics 0 0 0
Coverage 89.36% 89.36% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13123 13123 0
Failed 4101 4101 0
Panics 0 0 0
Coverage 76.19% 76.19% 0.00%

@ematipico ematipico merged commit 50557de into main Sep 21, 2023
16 checks passed
@ematipico ematipico deleted the chore/remove-atty branch September 21, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Parser Area: parser A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant