Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): don't create a new project when the configuration changes #3597

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #3577

The bug: a new project was always created when a configuration was updated.

The fix

  • we check if the project we registering is new or not. If not, we return the current key
  • we don't throw an error if the manifest isn't found

I took the opportunity to do some minor refactors:

  • more trace logging
  • print the error in there's a failure inside the LSP

Test Plan

I tested it manually, as I was able to reproduce it locally. Now bug is gone and the Biome LSP doesn't crush anymore

@ematipico ematipico requested review from a team August 6, 2024 09:55
@github-actions github-actions bot added A-Project Area: project A-LSP Area: language server protocol A-Changelog Area: changelog labels Aug 6, 2024
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is failing

@github-actions github-actions bot added the A-CLI Area: CLI label Aug 6, 2024
@ematipico ematipico merged commit 47cc739 into main Aug 6, 2024
13 checks passed
@ematipico ematipico deleted the fix/check-for-current-project branch August 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-LSP Area: language server protocol A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Biome extension does not follow the local configuration
2 participants