Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_formatter): add parens to match Prettier #3552

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Conaclos
Copy link
Member

Summary

Add parentheses for:

  • function types with an asserts return type inside a conditional type.
  • assertion type inside a shift-left operation

Test Plan

I updated the snapshots.

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jul 31, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48452 48452 0
Passed 47254 47254 0
Failed 1198 1198 0
Panics 0 0 0
Coverage 97.53% 97.53% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6544 6544 0
Passed 2197 2197 0
Failed 4347 4347 0
Panics 0 0 0
Coverage 33.57% 33.57% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18328 18328 0
Passed 14020 14020 0
Failed 4308 4308 0
Panics 0 0 0
Coverage 76.49% 76.49% 0.00%

@Conaclos Conaclos merged commit 79c3bdd into main Jul 31, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/add-missing-parens branch July 31, 2024 10:30
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant