refactor(js_formatter): remove NeedsParentheses::needs_parentheses_aith_parent
#3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
Conaclos
force-pushed
the
conaclos/remove-need-parens-with-parent
branch
from
f5b2e58
to
9c20286
Compare
CodSpeed Performance ReportMerging #3528 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
NeedsParentheses::needs_parentheses_aith_parent.This function creates an indirection and creates as much code as it avoids.
It was sometimes confusing to understand which function between
NeedsParentheses::needs_parenthesesandNeedsParentheses::needs_parentheses_aith_parentwas called because some code call one, and other call the other.Also, this leads to code duplication in
Any*impl.Test Plan
CI must pass.