refactor(js_formatter): reduce copy by taking ownership in needs_parentheses_with_parent
#3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
Conaclos
force-pushed
the
conaclos/needs-parens-tweak-ownerhip
branch
from
dd53982
to
76f967b
Compare
dyc3
approved these changes
Jul 26, 2024
Conaclos
changed the title
needs_parentheses_with_parentneeds_parentheses_with_parent
CodSpeed Performance ReportMerging #3526 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a minor refactoring that reduces node cloning by taking ownership of
parentinneeds_parentheses_with_parentTest Plan
CI must pass