Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consistently use cast, cast_ref and try_cast #3520

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jul 25, 2024

Summary

This PR tries to avoid node cloning by consistently using cast, cast_ref and try_cast.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Core Area: core A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Jul 25, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48369 48369 0
Passed 47172 47172 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.53% 97.53% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6544 6544 0
Passed 2197 2197 0
Failed 4347 4347 0
Panics 0 0 0
Coverage 33.57% 33.57% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18313 18313 0
Passed 14008 14008 0
Failed 4305 4305 0
Panics 0 0 0
Coverage 76.49% 76.49% 0.00%

Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #3520 will degrade performances by 6.18%

Comparing conaclos/node-cast-refactor (c8044b4) with main (bd7f6e1)

Summary

❌ 1 regressions
✅ 103 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/node-cast-refactor Change
dojo_11880045762646467684.js[cached] 8 ms 8.5 ms -6.18%

@Conaclos Conaclos merged commit ff21256 into main Jul 25, 2024
16 of 17 checks passed
@Conaclos Conaclos deleted the conaclos/node-cast-refactor branch July 25, 2024 15:33
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant