Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js_formatter): update prettier compat reports #3514

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Conaclos
Copy link
Member

Summary

Update compatibility reports between Biome and Prettier.

@Conaclos Conaclos changed the title refactor(js_formatter): update prettier compat reports chore(js_formatter): update prettier compat reports Jul 24, 2024
@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jul 24, 2024
Comment on lines +3455 to +3458
-import * as bar from "bar.json" assert {};
-import * as baz from "baz.json" /* comment */ assert {};
+import * as bar from "bar.json";
+import * as baz from "baz.json" /* comment */;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that they remove empty assertions is... weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I asked about that here: prettier/prettier#15757 (comment)

@Conaclos Conaclos merged commit 7d95bc3 into main Jul 24, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/js_formatter_report branch July 24, 2024 12:29
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants