-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js_formater): strip useless quotes #3492
Conversation
CodSpeed Performance ReportMerging #3492 will improve performances by 21.2%Comparing Summary
Benchmarks breakdown
|
Thanks! Could you rebase on main? I've just updated the Prettier snapshots. |
39a57ba
to
b1a9582
Compare
I have modified it, but I did not modify the code related to paser, I wonder why the performance has decreased |
It's a flaky benchmark , it's unrelated to your changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've just suggested a change of name because import assertion
is the old name of import attribute
.
Thank you for your review, I've done. |
122d2a1
to
9073a2e
Compare
Everything is green, except rust code formatting. Once formatted, we can merge the PR. |
Summary
fix(js_formater): strip useless quotes
#3484
Test Plan