refactor(core): register rules using visitor pattern #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3483 will not alter performanceComparing Summary
|
Conaclos
reviewed
Jul 22, 2024
ematipico
force-pushed
the
refactor/lint-rules-visitor
branch
from
8b729f8
to
c907590
Compare
Conaclos
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is just a refactor to make the linting code more DRY. It uses the
RegistryVisitorpattern, it accepts theLintParamstype and emits the enabled/disabled rules based on the configuration.I will attempt to make the code more DRY with other PRs.
Test Plan
The current tests should pass