Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_analyze): handle shorthand property renaming #3454

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #3050

I also took the opportunity of removing some legacy code and improving the code:

  • Trivias are already transferred by replace_token: we don't need to do that manually.
  • We now have AnyJsIdentifierUsage to retrieve the name token.
  • I added more comments to make the code more comprehensible

Test Plan

I added a test in the useNamingConvention rule.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 16, 2024
Copy link

codspeed-hq bot commented Jul 16, 2024

CodSpeed Performance Report

Merging #3454 will not alter performance

Comparing conaclos/js-rename-util (1ab26e9) with main (8c2e254)

Summary

✅ 104 untouched benchmarks

@Conaclos Conaclos requested a review from a team July 16, 2024 19:58
@ematipico ematipico requested a review from a team July 17, 2024 08:03
@Conaclos Conaclos merged commit 7188856 into main Jul 17, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/js-rename-util branch July 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 rename_node_declaration have error case for JsShorthandPropertyObjectMember
2 participants