Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useConsistentCurlyBraces): specify correct language type #3452

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

chansuke
Copy link
Member

Summary

This is a small fix.
As part of reviewing the jsx code, I discovered the following. I believe it should be specified as jsx.

    /// ### Valid
    ///
    /// ```js // should be jsx?
    /// <>
    ///     <Foo>Hello world</Foo>
    ///     <Foo foo="bar" />
    ///     <Foo foo={5} />
    ///     <Foo foo={<Bar />} />
    /// </>
    /// ```

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 16, 2024
Copy link

codspeed-hq bot commented Jul 16, 2024

CodSpeed Performance Report

Merging #3452 will improve performances by 6.63%

Comparing chansuke:fix/use-valid-filetype (891e033) with main (60513de)

Summary

⚡ 1 improvements
✅ 107 untouched benchmarks

Benchmarks breakdown

Benchmark main chansuke:fix/use-valid-filetype Change
db_2930068967297060348.json[cached] 14.3 ms 13.4 ms +6.63%

Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fell free to merge :)

@chansuke chansuke merged commit 42f92cf into biomejs:main Jul 17, 2024
12 checks passed
@chansuke chansuke deleted the fix/use-valid-filetype branch July 17, 2024 03:45
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants