fix: noCommentText does not work when any other text is a child(#3298)

[ryo-ebata]

Summary

Changed logic to judge by regex, considering the case where a comment is inserted in the middle of a paragraph.

Expanded test cases and added explanation of rule.

The quick fix feature has also been developed to fix only the commented part.

Closes #3298

Test Plan

Invalid Case

Add comments, line breaks, etc. in sentences.

<>
    <div>// comment</div>
    <div>/* comment */</div>
    <div>/** comment */</div>
    <div>text /* comment */</div>
    <div>/* comment */ text</div>
    <div>
        text
        // comment
    </div>
    <div>
        /* comment */
        text
    </div>
    <div>
        // comment
        text
    </div>
    <div>
        /* comment
        comment */
    </div>
</>

Valid Case

<>
    <div>{/* comment */}</div>
    <div>{/** comment */}</div>
    <div className={"cls" /* comment */}></div>
    <div>text {/* comment */}</div>
    <div>{/* comment */} text</div>
</>

[codspeed-hq]

CodSpeed Performance Report

Merging #3446 will not alter performance

_{Comparing ryo-ebata:fix/#3298 (8c470f4) with main (6f8eade)}

Summary

✅ 104 untouched benchmarks

[chansuke]

This is just my preference (not a suggestion) for readability. What do you think?

let new_jsx_value = COMMENT_REGEX.replace_all(&node_text, |caps: &regex::Captures| {
    let comment = caps[0]
        .trim_start_matches("//")
        .trim_start_matches("/*")
        .trim_end_matches("*/")
        .trim();
    format!("{{/*{}*/}}", comment)
});

[ryo-ebata]

@chansuke
To accommodate Doc comments(like /** example */), the code has been changed as follows

let new_jsx_value = COMMENT_REGEX.replace_all(&node_text, |caps: &regex::Captures| {
    let comment = caps[0].trim();
    match comment {
        c if c.starts_with("//") => format!("{{/* {} */}}", c[2..].trim()),
        c if c.starts_with("/**") => format!("{{/** {} */}}", &c[3..c.len() - 2].trim()),
        c => format!("{{/* {} */}}", &c[2..c.len() - 2].trim()),
    }
});

If you have any suggestions for a better code, I welcome them!

[ematipico]

The previous suggestion was able to keep the spaces, but now we remove leading and trailing spaces between the word "comment".

Before: const·a4·=·<div>{/*·comment·*/}</div>;
Now: <div>text·{/*comment*/}</div>

[ryo-ebata]

@ematipico
thanks your check, I had missed it...
I fixed in this commit!
9c6f601