Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace biome_rowan::* type into biome type #3431

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

chansuke
Copy link
Member

Summary

Replaced rowan crate type and use the type that defined in syntax_node module

Test Plan

Tested all files with

just l
just test

@github-actions github-actions bot added A-Linter Area: linter A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jul 14, 2024
Copy link

codspeed-hq bot commented Jul 14, 2024

CodSpeed Performance Report

Merging #3431 will not alter performance

Comparing chansuke:refactor/replace-rowan-type (f2fb278) with main (f38cfa5)

Summary

✅ 108 untouched benchmarks

@chansuke chansuke changed the title reafactor: replace biome_rowan::* type into biome type refactor: replace biome_rowan::* type into biome type Jul 14, 2024
@chansuke chansuke marked this pull request as ready for review July 14, 2024 14:43
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you, feel free to merge it

@chansuke chansuke merged commit 60513de into biomejs:main Jul 16, 2024
13 checks passed
@chansuke chansuke deleted the refactor/replace-rowan-type branch July 16, 2024 05:56
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants