Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql_parser): separate binding and reference nodes #3427

Conversation

vohoanglong0107
Copy link
Contributor

Summary

Differentiate between binding nodes and reference nodes to prepare for semantic model

Test Plan

All tests should pass

@github-actions github-actions bot added the A-Tooling Area: internal tools label Jul 13, 2024
@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review July 13, 2024 09:11
Copy link

codspeed-hq bot commented Jul 13, 2024

CodSpeed Performance Report

Merging #3427 will degrade performances by 10.12%

Comparing vohoanglong0107:feat-graphql-parser-separate-binding-reference (3d0e70f) with main (d8a7dbc)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 105 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main vohoanglong0107:feat-graphql-parser-separate-binding-reference Change
graphql_formatter[schema_9328028900703568614.graphql] 1.6 ms 1.5 ms +7.26%
db_2930068967297060348.json[uncached] 15.1 ms 16.8 ms -10.12%
eucjp_4223654609205405644.json[uncached] 1,034.7 µs 965.7 µs +7.15%

@ematipico ematipico merged commit f38cfa5 into biomejs:main Jul 15, 2024
12 of 13 checks passed
@vohoanglong0107 vohoanglong0107 deleted the feat-graphql-parser-separate-binding-reference branch July 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants