Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js_parser): correctly parse break statements containing keywords #3422

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix(js_parser): correctly parse break statements containing keywords #3422

merged 2 commits into from
Jul 12, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Jul 12, 2024

Summary

Fixes #3410

Test Plan

Added a new test

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jul 12, 2024
ematipico
ematipico approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was faaaast!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 12, 2024

CodSpeed Performance Report

Merging #3422 will degrade performances by 6.89%

Comparing ah-yu:fix/break_stmt (e37ba8f) with main (2691f52)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ah-yu:fix/break_stmt Change
❌ react.production.min_3378072959512366797.js[cached] 1.9 ms 2 ms -6.89%
⚡ db_2930068967297060348.json[cached] 13.3 ms 12.5 ms +6.62%

@ah-yu ah-yu merged commit d8a7dbc into biomejs:main Jul 12, 2024
12 of 13 checks passed
@ah-yu ah-yu deleted the fix/break_stmt branch July 12, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Parser errors on for loop label named out
2 participants
@ah-yu @ematipico