Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js_semantic): reduce semantic data size and make some cleanup #3417

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Conaclos
Copy link
Member

Summary

This PR reduces the size of the semantic data models.
Also, I made some cleanup.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 11, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48299 48299 0
Passed 47102 47102 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6546 6546 0
Passed 2201 2201 0
Failed 4345 4345 0
Panics 0 0 0
Coverage 33.62% 33.62% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18264 18264 0
Passed 14000 14000 0
Failed 4264 4264 0
Panics 0 0 0
Coverage 76.65% 76.65% 0.00%

Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #3417 will degrade performances by 6.17%

Comparing conaclos/js_semantic-reduce-data-size (48d8387) with main (8eb0e8a)

Summary

❌ 1 regressions
✅ 107 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/js_semantic-reduce-data-size Change
dojo_11880045762646467684.js[cached] 7.9 ms 8.4 ms -6.17%

@Conaclos Conaclos merged commit 48387f6 into main Jul 11, 2024
15 of 16 checks passed
@Conaclos Conaclos deleted the conaclos/js_semantic-reduce-data-size branch July 11, 2024 22:10
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant