fix(lint/useHookAtTopLevel): don't flag jest function calls that look like hooks #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #3415 will not alter performanceComparing Summary
|
ematipico
reviewed
Jul 17, 2024
arendjr
approved these changes
Jul 17, 2024
ematipico
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jest has some functions that our heuristics flag as a react hook. This PR makes it so biome doesn't flag
jest.useFakeTimersandjest.useRealTimersas react hooks.fixes #3337
Test Plan
Honestly, I don't exactly have a clean reproduction for the linked issue.