chore(grit): add Grit testing infrastructure #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
force-pushed
the
grit_testing_infra
branch
from
e1314b6
to
8347a69
Compare
arendjr
commented
Jul 11, 2024
Comment on lines
+8
to
+19
| Range { | ||
| start: Position { | ||
| line: 1, | ||
| column: 4, | ||
| }, | ||
| end: Position { | ||
| line: 1, | ||
| column: 4, | ||
| }, | ||
| start_byte: 25, | ||
| end_byte: 28, | ||
| }, |
There was a problem hiding this comment.
The snapshot already highlights a bug, since the calculated line and column numbers are always the same, even if the byte ranges are correct. I didn't want to start bugfixing in the same PR however, so this will be a follow-up fix :)
arendjr
changed the title
CodSpeed Performance ReportMerging #3406 will degrade performances by 7.05%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds testing infrastructure so we can conveniently start adding snapshot tests for Grit patterns.
Test Plan
CI should pass.