-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add rule useStrictMode
#3370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Area: project
A-Linter
Area: linter
A-Parser
Area: parser
L-JavaScript
Language: JavaScript and super languages
A-Diagnostic
Area: diagnostocis
labels
Jul 7, 2024
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #3370 will degrade performances by 8.4%Comparing Summary
Benchmarks breakdown
|
ematipico
force-pushed
the
feat/use-strict-mode
branch
from
July 9, 2024 10:47
3c8696b
to
1130817
Compare
Conaclos
reviewed
Jul 9, 2024
Conaclos
reviewed
Jul 9, 2024
Co-authored-by: Victorien Elvinger <[email protected]>
Co-authored-by: Victorien Elvinger <[email protected]>
Conaclos
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Changelog
Area: changelog
A-Diagnostic
Area: diagnostocis
A-Linter
Area: linter
A-Parser
Area: parser
A-Project
Area: project
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new rule called
useStrictMode
that enforces the use of"use strict"
inside script files (CJS).This PR updates the logic of the workspace to "guess" the module kind by reading the
type
field inside the manifest.If the manifest has
"commonjs"
, all.js
files are marked as scripts.I know that
commonjs
is the default value, but nowadays, nobody uses it, they use some sort of bundler and transpiler to handle the transformation of the code. I'd be happy to change the default value to commonjs if you think it's the correct approach.Test Plan
Added tests