Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css_parser): fix CSS multiple ampersand support #3367

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

denbezrukov
Copy link
Contributor

Summary

Fix #3349

.test {
  && {
    color: pink;
  }
  div {
    &&& {
      color: pink;
    }
  }
}

Test Plan

cargo test

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS A-Changelog Area: changelog labels Jul 7, 2024
Copy link
Contributor

github-actions bot commented Jul 7, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48223 48223 0
Passed 47026 47026 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6538 6538 0
Passed 2149 2149 0
Failed 4389 4389 0
Panics 0 0 0
Coverage 32.87% 32.87% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18250 18250 0
Passed 13987 13987 0
Failed 4263 4263 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

Copy link

codspeed-hq bot commented Jul 7, 2024

CodSpeed Performance Report

Merging #3367 will not alter performance

Comparing fix/nested-amp (02dd9d1) with main (40727ca)

Summary

✅ 108 untouched benchmarks

@denbezrukov denbezrukov merged commit f6ca506 into main Jul 8, 2024
16 checks passed
@denbezrukov denbezrukov deleted the fix/nested-amp branch July 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 CSS multiple ampersand support
2 participants