Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useFilenamingConvention): accept filename in unicase #3356

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jul 5, 2024

Summary

Fix #3353

By fixing this issue, we also now accept filenames in unicase.
This aligns the behavior of useFilenamingConvention with the behavior of useNamingConvention.

Test Plan

I added two tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jul 5, 2024
@Conaclos Conaclos merged commit 1218c3a into main Jul 5, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/unicase-filename branch July 5, 2024 10:48
Copy link

codspeed-hq bot commented Jul 5, 2024

CodSpeed Performance Report

Merging #3356 will improve performances by 6.15%

Comparing conaclos/unicase-filename (15f0f3c) with main (7e485c2)

Summary

⚡ 1 improvements
✅ 107 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/unicase-filename Change
router_14177007973872119684.ts[cached] 2.2 ms 2.1 ms +6.15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useFilenamingConvention incorrectly erroring on _404.tsx
1 participant