Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codegen to include GraphQL #3301

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

ematipico
Copy link
Member

Summary

This is a follow-up PR for #3295

I adds codegen for GraphQL, so now they are included in the registry and correctly run.

Test Plan

I added a test

@ematipico ematipico requested review from a team June 27, 2024 08:04
@github-actions github-actions bot added A-Project Area: project A-Tooling Area: internal tools labels Jun 27, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50242 50242 0
Passed 49135 49135 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.80% 97.80% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6535 6535 0
Passed 2084 2084 0
Failed 4451 4451 0
Panics 0 0 0
Coverage 31.89% 31.89% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18246 18246 0
Passed 13982 13982 0
Failed 4264 4264 0
Panics 0 0 0
Coverage 76.63% 76.63% 0.00%

@ematipico
Copy link
Member Author

I am going to merge this, it should be safe and it will enable linting in the playground!

@ematipico ematipico merged commit f88b7b2 into main Jun 27, 2024
15 checks passed
@ematipico ematipico deleted the chore/update-codegen branch June 27, 2024 08:20
Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #3301 will not alter performance

Comparing chore/update-codegen (db71333) with chore/update-codegen (1ad3958)

Summary

✅ 90 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Project Area: project A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants