Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): useNodejsImportProtocol takes in dependencies in consideration #3285

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #3066

Test Plan

Added a new test case

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jun 25, 2024
@ematipico ematipico requested review from a team June 25, 2024 14:06
Copy link

codspeed-hq bot commented Jun 25, 2024

CodSpeed Performance Report

Merging #3285 will not alter performance

Comparing fix/nodejs-import-protocol (c2b2f56) with fix/nodejs-import-protocol (25d474c)

Summary

✅ 90 untouched benchmarks

@ematipico ematipico merged commit 519e316 into main Jun 25, 2024
14 checks passed
@ematipico ematipico deleted the fix/nodejs-import-protocol branch June 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useNodejsImportProtocol gets thrown although a npm package is installed with the same name
2 participants