Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrate): suppress node warnings #3259

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix(migrate): suppress node warnings #3259

merged 2 commits into from
Jun 22, 2024

Conversation

SuperchupuDev
Copy link
Member

@SuperchupuDev SuperchupuDev commented Jun 22, 2024 •
edited
Loading

Summary

Fixes #3104 by setting the NODE_NO_WARNINGS env variable

Test Plan

@github-actions github-actions bot added the A-CLI Area: CLI label Jun 22, 2024
@SuperchupuDev SuperchupuDev requested a review from a team June 22, 2024 16:49
Conaclos
Conaclos approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great fix :)

@Conaclos
Copy link
Member

Could you add a changelog entry? Feel free to merge once done.

@github-actions github-actions bot added the A-Changelog Area: changelog label Jun 22, 2024
@SuperchupuDev SuperchupuDev merged commit fc9b1eb into main Jun 22, 2024
13 checks passed
@SuperchupuDev SuperchupuDev deleted the superchupu/fix/suppress-node-warnings branch June 22, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Migration quit on node warning.
2 participants
@SuperchupuDev @Conaclos