Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql_formatter): bootstrap GraphQL formatter #3255

Merged
merged 11 commits into from
Jun 29, 2024

Conversation

denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented Jun 22, 2024

Summary

This PR bootstraps all of the infrastructure for biome_graphql_formatter, including:

  • the biome_graphql_formatter crate itself
  • configuration through biome_cli
  • configuration through biome_service

Test Plan

cargo test

@denbezrukov denbezrukov changed the title feat(graphql_formatter): Bootstrap GraphQL formatter feat(graphql_formatter): bootstrap GraphQL formatter Jun 22, 2024
@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Tooling Area: internal tools labels Jun 22, 2024
Copy link
Contributor

github-actions bot commented Jun 22, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50490 50490 0
Passed 49293 49293 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.63% 97.63% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6535 6535 0
Passed 2084 2084 0
Failed 4451 4451 0
Panics 0 0 0
Coverage 31.89% 31.89% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18246 18246 0
Passed 13982 13982 0
Failed 4264 4264 0
Panics 0 0 0
Coverage 76.63% 76.63% 0.00%

Copy link

codspeed-hq bot commented Jun 22, 2024

CodSpeed Performance Report

Merging #3255 will not alter performance

Comparing feat/graphql-formatter (342491a) with main (c4ffa64)

Summary

✅ 90 untouched benchmarks

@denbezrukov denbezrukov marked this pull request as ready for review June 22, 2024 14:01
@denbezrukov denbezrukov requested review from a team June 22, 2024 14:01
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here! Are we ready to merge it? I haven't seen reports for concerning bugs that would require a 1.8.3 release.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you didn't create the new crates using just new-crate. Can you update knope.toml to add the new crates?

@denbezrukov
Copy link
Contributor Author

Great job here! Are we ready to merge it? I haven't seen reports for concerning bugs that would require a 1.8.3 release.

I think so. I know only some fixes for css. #3251 #3257 #3254
If we have to release something, the formatter is disabled by default, and IDEs require an update to support formatting.

@ematipico
Copy link
Member

Great job here! Are we ready to merge it? I haven't seen reports for concerning bugs that would require a 1.8.3 release.

I think so. I know only some fixes for css. #3251 #3257 #3254 If we have to release something, the formatter is disabled by default, and IDEs require an update to support formatting.

Then we should at least hide all the CLI options, so we can safely merge this PR. Or we can wait a little bit until we ship a new patch release

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Agreed we may want to hide the CLI options until the formatter is ready, other than that, looks good 👍

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter labels Jun 27, 2024
@denbezrukov
Copy link
Contributor Author

@ematipico Could we merge it?

@ematipico ematipico self-requested a review June 29, 2024 09:09
@denbezrukov denbezrukov merged commit d785012 into main Jun 29, 2024
16 checks passed
@denbezrukov denbezrukov deleted the feat/graphql-formatter branch June 29, 2024 09:12
rishabh3112 pushed a commit to rishabh3112/biome that referenced this pull request Jul 6, 2024
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Formatter Area: formatter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants