Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analyzer): improve contributing guide for rules with multiple signals #3245

Merged

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented Jun 20, 2024

Summary

While working on #3241 I found it difficult to apply diagnostic, for multiple ranges. I found answer on Discord but that was not very obvious, so it should prob be documented.

It is bit rough, but I hope this can be starting point.

Test Plan

not needed

@github-actions github-actions bot added the A-Linter Area: linter label Jun 20, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thank you

It's not that easy to keep the contribution guide up to date

@ematipico ematipico merged commit bb5faa0 into biomejs:main Jun 24, 2024
10 checks passed
@minht11 minht11 deleted the docs/improve-analyzer-multiple-signals branch June 24, 2024 12:39
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants