chore(grit): improve snippet compiler #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
commented
Jun 16, 2024
| @@ -237,262 +226,3 @@ impl PatternCompiler { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| impl PatternCompiler { | |||
| pub(crate) fn from_snippet_node( | |||
There was a problem hiding this comment.
This method has been refactored and moved to snippet_compiler.rs, since that's where it's used anyway.
CodSpeed Performance ReportMerging #3223 will not alter performanceComparing Summary
|
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains many updates to the bindings again, including a major change to align the bindings closer to the semantics expected by Grit. In short, this means that nodes in the Grit bindings can be either nodes or tokens in Biome terminology.
This helped me to make some significant progress on the snippet compiler, which has been heavily revisited in general. I have added a few internal tests which show that a Grit literal snippet with embedded JS content gets properly compiled to a Grit pattern with the nodes matching Biome's parsed CST.
This brings me again a step closer to matching patterns, since we now have a valid pattern to match against.
Test Plan
Added some tests.