Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useLiteralKeys): unescaped newline false positive #3210

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

Sec-ant
Copy link
Member

@Sec-ant Sec-ant commented Jun 14, 2024

Summary

Fixes #3160. This rule now ignores the following kind of computed member name:

const a = {
  [`line1
  line2`]: true,
};

Test Plan

Test cases added.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jun 14, 2024
@Sec-ant Sec-ant requested review from a team June 14, 2024 09:13
Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #3210 will not alter performance

Comparing fix/use-literal-keys (3e284b5) with fix/use-literal-keys (350cbc1)

Summary

✅ 90 untouched benchmarks

@Sec-ant Sec-ant merged commit 743d805 into main Jun 14, 2024
14 checks passed
@Sec-ant Sec-ant deleted the fix/use-literal-keys branch June 14, 2024 14:10
@Sec-ant Sec-ant restored the fix/use-literal-keys branch June 18, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 There is a false positive in the useLiteralKeys rule
3 participants