Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css_formatter): correctly resolve css format options #3170

Merged
merged 4 commits into from
Jun 11, 2024
Merged

fix(css_formatter): correctly resolve css format options #3170

merged 4 commits into from
Jun 11, 2024
+56 −22

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Jun 11, 2024

Summary

Closes #3103

Test Plan

  • add a new test
  • update an existing test and a snapshot

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Formatter Area: formatter L-CSS Language: CSS A-Changelog Area: changelog labels Jun 11, 2024
ematipico
ematipico approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3170 will not alter performance

Comparing ah-yu:fix/css_fmt_cfg (6cac7b3) with main (8338f8e)

Summary

✅ 92 untouched benchmarks

@ah-yu ah-yu merged commit 0b1592b into biomejs:main Jun 11, 2024
12 checks passed
@ah-yu ah-yu deleted the fix/css_fmt_cfg branch June 11, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Formatter Area: formatter A-Project Area: project L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Css formatter doesn't inherit global formatter settings
2 participants
@ah-yu @ematipico