Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): improve rules_check task #3165

Merged
merged 4 commits into from
Jun 11, 2024
Merged

chore(ci): improve rules_check task #3165

merged 4 commits into from
Jun 11, 2024

Conversation

Sec-ant
Copy link
Member

@Sec-ant Sec-ant commented Jun 10, 2024

Summary

  • Discard BlockType and use DocumentFileSource as the single source of truth.
  • Retain the code block tag from the input instead of regenerating it.
  • Use code-block.{js,css,json...} as the file path displayed in code block diagnostics.

I will apply the same modifications to the codegen task in the website repo after this is merged.

Test Plan

CI should pass.

@github-actions github-actions bot added A-Parser Area: parser A-Tooling Area: internal tools L-JSON Language: JSON and super languages labels Jun 10, 2024
bail!("Unrecognised block type {}", &block)
}
// Unknown code blocks should be already ignored by tests
DocumentFileSource::Unknown => {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more forgiving here, in case we want to add some foreign code blocks (like shell) for illustration purpose.

Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50787 50787 0
Passed 49680 49680 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6534 6534 0
Passed 2087 2087 0
Failed 4447 4447 0
Panics 0 0 0
Coverage 31.94% 31.94% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18217 18217 0
Passed 13961 13961 0
Failed 4256 4256 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #3165 will not alter performance

Comparing ci/rule-check (7f65f5d) with main (5d76e45)

Summary

✅ 92 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Parser Area: parser A-Tooling Area: internal tools L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants