Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: format package.json like npm does #3155

Merged
merged 3 commits into from
Jun 10, 2024
Merged

chore: format package.json like npm does #3155

merged 3 commits into from
Jun 10, 2024

Conversation

ematipico
Copy link
Member

Summary

This change will fix the issue that popped up here: #3145

Test Plan

CI should pass

@Sec-ant
Copy link
Member

Sec-ant commented Jun 10, 2024 •
edited
Loading

We should also run npm pkg fix for each of the package to fix the bin and repository field. The latter one will enable us to use the compact option of pkg.pr.new: https://github.com/stackblitz-labs/pkg.pr.new/blob/fc43e0bbbdf4f5e8c4d40da2c806a5cff8cff1fe/packages/utils/index.ts#L4

@ematipico
Copy link
Member Author

Done in 8177dd9 (#3155)

@ematipico ematipico merged commit da6f180 into main Jun 10, 2024
6 checks passed
@ematipico ematipico deleted the chore/package-formatting branch June 10, 2024 10:09
@Sec-ant Sec-ant mentioned this pull request Jun 11, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 2, 2024
Merged
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Changelog Area: changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @Sec-ant @Conaclos