Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(biome_js_analyzer): noSubstr #3125

Merged
merged 30 commits into from
Jun 11, 2024
Merged

feat(biome_js_analyzer): noSubstr #3125

merged 30 commits into from
Jun 11, 2024

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Jun 8, 2024

Summary

Part of #2817

Test Plan

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Jun 8, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3125 will not alter performance

Comparing chansuke:feat/no-substr (03bd592) with main (535acc7)

Summary

✅ 92 untouched benchmarks

@chansuke chansuke marked this pull request as ready for review June 8, 2024 07:51
@chansuke chansuke requested a review from Sec-ant June 8, 2024 07:51
Sec-ant
Sec-ant reviewed Jun 8, 2024
View reviewed changes
Copy link
Member

@Sec-ant Sec-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the wording of the messages, maybe others can give you more advice.

crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
minht11
minht11 reviewed Jun 8, 2024
View reviewed changes
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/tests/specs/nursery/noSubstr/valid.js Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
@chansuke chansuke requested review from minht11 and Sec-ant June 8, 2024 09:37
@chansuke chansuke requested a review from Conaclos June 9, 2024 05:48
@chansuke chansuke requested a review from Sec-ant June 9, 2024 16:28
ematipico
ematipico approved these changes Jun 10, 2024
View reviewed changes
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_substr.rs Outdated Show resolved Hide resolved
@ematipico
Copy link
Member

I added String. because slice is a Array function too.

@github-actions github-actions bot added the A-CLI Area: CLI label Jun 10, 2024
@ematipico ematipico merged commit 4a7baaa into biomejs:main Jun 11, 2024
12 checks passed
@ramzimalhas ramzimalhas mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 28, 2024
Open
Open
@Ramyromel Ramyromel mentioned this pull request Sep 9, 2024
Open
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
@Ramyromel Ramyromel mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@minht11 minht11 Awaiting requested review from minht11

@Conaclos Conaclos Awaiting requested review from Conaclos

@Sec-ant Sec-ant Awaiting requested review from Sec-ant

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chansuke @ematipico @Conaclos @minht11 @Sec-ant