Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql_parser): allow backlash in block string #3113

Conversation

vohoanglong0107
Copy link
Contributor

Summary

According to the GraphQL documentation, backslash characters can be used unescaped within a block string (link).

Test Plan

All tests should pass.

Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #3113 will not alter performance

Comparing vohoanglong0107:fix-graphql-parser-allow-backlash-in-block-string (c3dbf93) with main (38abf5e)

Summary

✅ 92 untouched benchmarks

@vohoanglong0107 vohoanglong0107 force-pushed the fix-graphql-parser-allow-backlash-in-block-string branch from 6bb4cbb to c3dbf93 Compare June 8, 2024 00:40
@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review June 8, 2024 01:17
@arendjr arendjr merged commit 2f4997b into biomejs:main Jun 8, 2024
12 checks passed
@vohoanglong0107 vohoanglong0107 deleted the fix-graphql-parser-allow-backlash-in-block-string branch June 25, 2024 08:58
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants