feat(graphql_parser): parse input object type extension #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3112 will not alter performanceComparing Summary
|
vohoanglong0107
force-pushed
the
feat-graphql-parse-input-extension
branch
from
e7205f1
to
d9908aa
Compare
arendjr
approved these changes
Jun 8, 2024
| 5 │ y: Float | ||
| 6 │ } | ||
|
|
||
| i Remove x |
There was a problem hiding this comment.
I feel this suggestion could be improved.
There was a problem hiding this comment.
I will create a new PR to address this, as the current PR does not modify this behavior but only copies the error message from the input object definition rule. What would you suggest for the new suggestion?
There was a problem hiding this comment.
It seems the code could be fixed by adding the {, so maybe a suggestion along the lines of “did you forget to add the {”?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parse GraphQL input object extensions (link). We should be ready to benchmark the GraphQL parser after this.
Test Plan
All tests should pass.