Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use-adjacent-overload-signature diagnostic #3095

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix: use-adjacent-overload-signature diagnostic #3095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca91573
fix(use-adjacent-overload-signature): update snapshot for latest logic
chansuke Jun 6, 2024
9a84926
chore(use-adjacent-overload-signature): update method name
chansuke Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/biome_js_analyze/tests/specs/nursery/useAdjacentOverloadSignatures/invalid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ class C {
}

class D {
fooB(s: string): void;
fooB(s: string): void;
barB(): void {};
fooB(n: number): void;
fooB(sn: string | number): void {};
fooB(sn: string | number): void {};
fooD(s: string): void;
fooD(s: string): void;
barD(): void {};
fooD(n: number): void;
fooD(sn: string | number): void {};
fooD(sn: string | number): void {};
}

export function foo(s: string): void;
Expand Down
24 changes: 12 additions & 12 deletions crates/biome_js_analyze/tests/specs/nursery/useAdjacentOverloadSignatures/invalid.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ class C {
}

class D {
fooB(s: string): void;
fooB(s: string): void;
barB(): void {};
fooB(n: number): void;
fooB(sn: string | number): void {};
fooB(sn: string | number): void {};
fooD(s: string): void;
fooD(s: string): void;
barD(): void {};
fooD(n: number): void;
fooD(sn: string | number): void {};
fooD(sn: string | number): void {};
}

export function foo(s: string): void;
Expand Down Expand Up @@ -200,14 +200,14 @@ invalid.ts:40:3 lint/nursery/useAdjacentOverloadSignatures ━━━━━━━
```
invalid.ts:50:3 lint/nursery/useAdjacentOverloadSignatures ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! All fooB signatures must be adjacent.
! All fooD signatures must be adjacent.

48 │ fooB(s: string): void;
49 │ barB(): void {};
> 50 │ fooB(n: number): void;
48 │ fooD(s: string): void;
49 │ barD(): void {};
> 50 │ fooD(n: number): void;
│ ^^^^
51 │ fooB(sn: string | number): void {};
52 │ fooB(sn: string | number): void {};
51 │ fooD(sn: string | number): void {};
52 │ fooD(sn: string | number): void {};


```
Expand Down