Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(useNamingConvention): fix conventions example #3070

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jun 5, 2024

Summary

Fix the example of the conventions option.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 5, 2024
@Conaclos Conaclos merged commit be5ccd5 into main Jun 5, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/useNamingConvention/fix-docs branch June 5, 2024 13:22
Copy link

codspeed-hq bot commented Jun 5, 2024

CodSpeed Performance Report

Merging #3070 will degrade performances by 6.07%

Comparing conaclos/useNamingConvention/fix-docs (b5cc6aa) with main (4ce2144)

Summary

❌ 1 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/useNamingConvention/fix-docs Change
dojo.js[cached] 8 ms 8.5 ms -6.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant