-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: delete stale snapshots #3062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for helping catch the descrepencies. However there're two kinds of changes in this PR that need to be reverted:
- Prettier uses the singular form
trailingComma
as its option name, we shouldn't change that. - We have some tests to check that we can handle the deprecated option name
tailingComma
, so we shouldn't change them.
The changes in the test snapshots seem expected. However I'm not sure why they weren't catched earlier? Did you run the tests to update the snapshots or did you just replace them by hand?
crates/biome_js_formatter/tests/specs/prettier/js/objects/range.js
Outdated
Show resolved
Hide resolved
crates/biome_js_formatter/tests/specs/prettier/js/objects/range.js.prettier-snap
Outdated
Show resolved
Hide resolved
crates/biome_service/tests/valid/deprecated_options_inside_javascript.json
Outdated
Show resolved
Hide resolved
crates/biome_migrate/tests/specs/migrations/trailingComma/invalid.json
Outdated
Show resolved
Hide resolved
I did not understand the project well and updated it manually. @Sec-ant |
I'm sorry that I checked incorrectly and caused you trouble when you could easily fix it. I have corrected everything you mentioned, and if there is anything else that needs to be corrected, please let me know. |
I see. Test snapshots reflect the behavior of the source code and test cases, they are meant to catch unexpected regressions. So they should only be mutated when the source code or test cases change their behavior, and we shouldn't change them manually. That being said, the snapshots updated by this PR are actually stale snapshots that should be deleted. I'll just edit in your branch. Thanks for catching them. |
Summary
hello. I am one of the users who watches biome closely because I feel frustrated with the speed of using eslint.
recently, the trailingComma property has been changed to trailingCommas, but it seems to remain as trailingComma in some documents.
so, I felt it was necessary to revise the document so that others would not have to go through the same trial and error as me.
If the modification is incorrect, you may make additional corrections.
and thank you for making a great product.
Test Plan