Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): incorrect snippets #3059

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(docs): incorrect snippets #3059

merged 1 commit into from
Jun 4, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Jun 4, 2024

Summary

@togami2864 noEmptyBlock snippet fails, please fix it whenever you can
@minht11 a snippet is failing, it's not returning any diagnostics. Please fix it
@chansuke next time, please make sure that the code blocks are correct. Also, one of the code snippets didn't emit diagnostics. Please fix it
@fujiyamaorange please, next time make sure to put valid code inside the snippets

Test Plan

Merge it. It will fix the website

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS labels Jun 4, 2024
@ematipico ematipico merged commit 6cff2f3 into main Jun 4, 2024
14 checks passed
@ematipico ematipico deleted the fix/incorrect-docs branch June 4, 2024 17:39
@minht11
Copy link
Contributor

minht11 commented Jun 4, 2024

@ematipico how can see what diagnostic was or was not generated?

@ematipico
Copy link
Member Author

ematipico commented Jun 4, 2024

The code that checks that is in the website repository for now. We plan to bring it back here. You should run cargo run -p codegen rules.

Anyway, the cases that are failing aren't inside the tests, so we should at least make sure that we use invalid cases that are covered by our tests.

We have import "./foo/"; but not import "./foo";

Copy link

codspeed-hq bot commented Jun 4, 2024

CodSpeed Performance Report

Merging #3059 will improve performances by 6.97%

Comparing fix/incorrect-docs (c34d3de) with main (378c05e)

Summary

⚡ 1 improvements
✅ 91 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/incorrect-docs Change
pure.css[cached] 4 ms 3.7 ms +6.97%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants