Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): biome init won't generate config file if biome.jsonc already exists #3035

Merged
merged 2 commits into from
Jun 1, 2024
Merged

fix(cli): biome init won't generate config file if biome.jsonc already exists #3035

merged 2 commits into from
Jun 1, 2024

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented Jun 1, 2024

Summary

Fix #3024

Test Plan

Added tests

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Changelog Area: changelog labels Jun 1, 2024
ematipico
ematipico approved these changes Jun 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 312e46f into biomejs:main Jun 1, 2024
2 checks passed
@minht11 minht11 deleted the fix/biome-init-if-jsonc-exists branch June 1, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Project Area: project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 biome init creates biome.json even if biome.jsonc already exists
2 participants
@minht11 @ematipico