Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(biome_js_analyze): use rustc_hash::FxHashSet; and reduce allocation #3004

Merged

Conversation

chansuke
Copy link
Member

Summary

Closes #2951

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels May 27, 2024
Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #3004 will not alter performance

Comparing chansuke:refactor/reduce-the-number-of-allocation (9860c55) with main (e4644da)

Summary

✅ 92 untouched benchmarks

@chansuke chansuke marked this pull request as ready for review May 27, 2024 16:23
@Conaclos Conaclos self-requested a review May 27, 2024 20:40
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor! Thanks :)

@Conaclos Conaclos merged commit 5e96827 into biomejs:main May 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Improve useAdjacentOverloadSIgnatures implementation
2 participants