refactor: make suppression action generic via trait #2955
Merged
+439
−235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The suppression action system was tied to the JS language.
This refactors the system by making it generic using a trait called
SuppressionAction
insidebiome_analyze
.Users will need to implement two functions:
ApplySuppression
, which contains info on where and how to apply the mutationThe CSS and JSON languages don't have suppression actions at this time.
The idea is to land a PR that applies suppression to CSS lint rules. @togami2864 I think we need to land at least a basic heuristic to apply suppression comments; otherwise, people won't see the "Quick fix" tooltip in the IDEs/editors.
Test Plan
The current CI should work.