Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): pull diagnostics for CSS files #2937

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

ematipico
Copy link
Member

Summary

Adds support for pulling diagnostics from CSS file analysis.

I didn't add the fix_all test because we don't have rules that apply a code action yet.

Once we merge this PR, clients will need to update the plugins to enable them for CSS files too.

I already sent a PR for the VSCode extension: biomejs/biome-vscode#222

We should do the same for biome-intellij and biome-zed. Help would be appreciated!!

Test Plan

Added a new test case

@ematipico ematipico requested review from a team May 21, 2024 10:37
@github-actions github-actions bot added A-Project Area: project A-LSP Area: language server protocol labels May 21, 2024
@ematipico ematipico merged commit 27b0abe into main May 22, 2024
13 checks passed
@ematipico ematipico deleted the feat/enable-code-actions-css branch May 22, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LSP Area: language server protocol A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant