refactor(lint/useTopLevelRegex): ignore regular expressions with the g and/or y flags
#2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #2926 will not alter performanceComparing Summary
|
Conaclos
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thanks!
@lucasweng Could you update the rule description to add a paragraph about this exception and an example in Valid?
Conaclos
approved these changes
May 21, 2024
lucasweng
deleted the
refactor/useTopLevelRegex/ignore-regex-with-gy-flags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useTopLevelRegex: Handle regex flags correctly #2872Test Plan
I updated the tests.