Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): remove unused NoColorInvalidHex #2909

Merged
merged 3 commits into from
May 18, 2024

Conversation

togami2864
Copy link
Contributor

Summary

I added it temporary for testing purposes, but since we are not sure if we will implement it, I'll remove it.

Test Plan

@github-actions github-actions bot added A-Project Area: project L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels May 18, 2024
@togami2864 togami2864 self-assigned this May 18, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because you have to remove the tests too

Copy link

codspeed-hq bot commented May 18, 2024

CodSpeed Performance Report

Merging #2909 will not alter performance

Comparing togami2864:chore/remove-css-hex (a60db57) with main (62d1f71)

Summary

✅ 99 untouched benchmarks

@ematipico ematipico merged commit a678c68 into biomejs:main May 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostic Area: diagnostocis A-Project Area: project L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants