feat(configuration): add the fix
rule option
#2892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2882
To reuse
FixKind
, I had to add a new variantFixKind::None
.We now use
FixKind::None
for all rules without code action.The configured fix kind of a rule is passed to the analyzer in the same way as we pass rule options.
If it is not set, then we use the default fix kind/applicability of the rule.
Otherwise, we use the configured fix kind to set the applicability of an action.
When the fix kind is configured to
FixKindNone
, we prevent calling the ruleaction
method.Test Plan
I added new tests.